fix: #6682 #7247
Merged
fix: #6682 #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure element styles set via pt merge with required `xBarRef` and `yBarRef` styles The following styles for "barX" can not be overridden: - width - left - bottom The following styles for "barY" can not be overridden: - height - top - right
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
- Fix static method to properly make use of `style` parameter - Update typing
gcko
commented
Sep 25, 2024
| @@ -1055,9 +1055,9 @@ export default class DomHandler { | |||
|
|
|||
| static applyStyle(element, style) { | |||
| if (typeof style === 'string') { | |||
| element.style.cssText = this.style; | |||
| element.style.cssText = style; | |||
There was a problem hiding this comment.
@melloware I updated DomHandler.applyStyle to correctly "apply" the passed in style parameter.
melloware
approved these changes
Sep 25, 2024
melloware
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
fix: #6682
xBarRefandyBarRefstylesThe following styles for "barX" can not be overridden:
The following styles for "barY" can not be overridden: