Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollpanel: pt barX is gets overwritten when mouse enters scrollpanel #6682

Closed
PrebenTjemsland opened this issue May 27, 2024 · 1 comment · Fixed by #7247
Closed

Scrollpanel: pt barX is gets overwritten when mouse enters scrollpanel #6682

PrebenTjemsland opened this issue May 27, 2024 · 1 comment · Fixed by #7247
Assignees
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Milestone

Comments

@PrebenTjemsland
Copy link

Describe the bug

The Pass Through for barX on Scrollpanel is overwritten when you hover on the panel.

Initial:
element.style {
opacity: 0;
width: 40px;
}

after hover:
element.style {
width: 97.2366%;
left: 0%;
bottom: -416px;
}

Reproducer

https://stackblitz.com/edit/vitejs-vite-jcmten?file=src%2FApp.tsx

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 125

Steps to reproduce the behavior

Make a scrollpanel with content styled with style={{ margin: 8, width: '100%' }}
Add pt for barX
hover on panel

Expected behavior

pt stays on mouse enter

@PrebenTjemsland PrebenTjemsland added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 27, 2024
@melloware melloware added Component: Unstyled Issue related to unstyled/passthrough attributes and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 27, 2024
gcko added a commit to gcko/primereact that referenced this issue Sep 25, 2024
- Ensure element styles set via pt merge with required `xBarRef` and `yBarRef` styles

The following styles for "barX" can not be overridden:
 - width
 - left
 - bottom

 The following styles for "barY" can not be overridden:
 - height
 - top
 - right
@gcko gcko mentioned this issue Sep 25, 2024
@gcko
Copy link
Contributor

gcko commented Sep 25, 2024

Hey @PrebenTjemsland I created a pr to address the overwritten style issue - note the override issue also affected the y scrollbar as well.

One thing to note: for barX and barY there are a few styles that are there for UI consistency, thus in my fix any overrides for those will be ignored. The good folks at primefaces will have to weigh in if they feel that can be adjusted cc @melloware

The following styles for "barX" can not be overridden:

  • width
  • left
  • bottom

The following styles for "barY" can not be overridden:

  • height
  • top
  • right

@melloware melloware added this to the 10.8.4 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants