Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 7201 Fix issue related to optional parameter #7212

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

gcko
Copy link
Contributor

@gcko gcko commented Sep 18, 2024

Defect Fixes

Fix #7201 - Fix issue related to optional parameter

In TabView.js method getTabPT, the return parameter is as follows:

return mergeProps(ptm(`tab.${key}`, { tab: tabMetaData }), ptm(`tabpanel.${key}`, { tabpanel: tabMetaData }), ptm(`tabpanel.${key}`, tabMetaData), ptmo(getTabProp(tab, 'pt'), key, tabMetaData));

Multiple method calls to tabpanel.${key} occur with different parameters - the first call nests tabMetaData in tabpanel, and the subsequent call does not nest the parameters.

Because of this, props, parent, and context are optional (i.e. they could be undefined). This PR fixes the issue, however as an aside the typing needs to be fixed in tabview.d.ts for TabViewPassThroughMethodOptions

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 8:53am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 8:53am

@melloware melloware merged commit 30fffbd into primefaces:master Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView: 10.8.3 Unstyled not working
2 participants