Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView: 10.8.3 Unstyled not working #7201

Closed
edysmp opened this issue Sep 17, 2024 · 3 comments · Fixed by #7212
Closed

TabView: 10.8.3 Unstyled not working #7201

edysmp opened this issue Sep 17, 2024 · 3 comments · Fixed by #7212
Assignees
@gcko @edysmp
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.8.4

Comments

@edysmp
Copy link

edysmp commented Sep 17, 2024

Describe the bug

Uncaught TypeError: Cannot read properties of undefined (reading 'state')
at headerAction

Reproducer

https://primereact.org/tabview/

System Information

"primereact": "10.8.3"

Steps to reproduce the behavior

https://primereact.org/tabview/ > Theming > Unstyled > Tailwind demo.

Expected behavior

tabs render.
@edysmp edysmp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 17, 2024
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 17, 2024
@melloware
Copy link
Member

@gcko Is this just a matter of the Showcase being wrong after the fix you made?

@gcko
Copy link
Contributor

gcko commented Sep 17, 2024

I'll look at it tomorrow

@edysmp
Copy link
Author

edysmp commented Sep 17, 2024

adding extra checking: parent?.state?.activeIndex !== context?.index at https://github.com/primefaces/primereact/blob/master/components/lib/passthrough/tailwind/index.js#L266 is a workaround.

@melloware melloware added this to the 10.8.4 milestone Sep 17, 2024
gcko added a commit to gcko/primereact that referenced this issue Sep 18, 2024
@gcko
fix: primefaces#7201 Fix issue related to optional parameter
0a809cf
gcko added a commit to gcko/primereact that referenced this issue Sep 18, 2024
@gcko
fix: primefaces#7201 Update tailwinddoc.js for tabview
330aa2c
This was referenced Sep 18, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcko gcko

@edysmp edysmp

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.8.4
Development

Successfully merging a pull request may close this issue.

Fix: 7201 Fix issue related to optional parameter gcko/primereact
3 participants
@gcko @melloware @edysmp