Fix #6039: splitter bug fixes #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move step typing to correct element - move role=separator to correct element (per spec should be on the same element that contains aria-orientation and aria-value* attribs) - see https://www.w3.org/TR/wai-aria-1.2/#separator - fix bug where if home/end/enter were used in a splitter that has a minSize, after pressing those buttons, the arrow keys would no longer work
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
added
the
Component: Accessibility
melloware
approved these changes
Feb 24, 2024
|
@melloware do I need to do anything more at this point, I was assuming it's all in the core team's hands now but thought I should double check. Thanks! |
|
Yep the core team will review and merge it for me it looks perfect. |
nitrogenous
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6039
for issue #6039
move step typing to correct element
move role=separator to correct element (per spec should be on the same element that contains aria-orientation and aria-value* attribs) - see https://www.w3.org/TR/wai-aria-1.2/#separator
fix bug where if home/end/enter were used in a splitter that has a minSize, after pressing those buttons, the arrow keys would no longer work
for this issue #6039