Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter: Accessibility updates #6039

Closed
shawnharvell opened this issue Feb 24, 2024 · 3 comments · Fixed by #6040
Closed

Splitter: Accessibility updates #6039

shawnharvell opened this issue Feb 24, 2024 · 3 comments · Fixed by #6040
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone

Comments

@shawnharvell
Copy link
Contributor

Describe the bug

There are a few small bugs in the Splitter component:

  • role="separator" is on the wrong element, it should be on the gutter handle element where the other aria attributes are located (in particular, the aria-orientation attribute)
  • the documentation indicates that the step property belongs to SplitterPanel, however when you look at the code it's clear that really it goes on Splitter itself, this is simply a bug in the typescript typing file that results in the documentation appearing incorrect
  • if you use minSize on a SplitterPanel, when you try to use Home/End/Enter keys for maximize/minimize behavior, then the arrow keys stop working

I've actually coded fixes for this in my local cloned repo that seem to be working great BUT I am unable to push a branch to the repo to create a PR as GitHub says I do not have write access. If I could be given that access I'd be glad to push and PR OR alternatively would be glad to somehow share the code changes I made with somone who can do it.

Reproducer

No response

PrimeReact version

10.5.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@shawnharvell shawnharvell added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 24, 2024
@melloware
Copy link
Member

you have to fork the repo. You can't push directly to this repo you have to fork it, make changes in your fork and it will submit a PR from there.

See: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 24, 2024
@melloware melloware added this to the 10.5.2 milestone Feb 24, 2024
@melloware melloware changed the title Some bugs in the Splitter component Splitter: Accessibility updates Feb 24, 2024
@shawnharvell
Copy link
Contributor Author

thanks @melloware PR #6040

@melloware
Copy link
Member

Thanks it's great. I am going to make these same changes in PrimeFaces JSF.

nitrogenous added a commit that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants