fixes #3200 Add Generics to #3211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Generics for Dropdown. Generics have to be also added in: cascadeselect.d.ts listbox.d.ts multiselect.d.ts selectbutton.d.ts because of the SelectItemOptionsType
… Multiselect, Selectbutton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Generics to Dropdown, Listbox, Multiselect and Selectbutton #3200
Gives Autocomplete to the
optionValueoptionLabelopionGroupLabelandoptionGroupChildrenProps while still allowing all String values:optionLabel?: NestedKeyOf<TOption> | Omit<NestedKeyOf<TOption>, string>;The Omit makes that VS-Code Autocompletes.
if you would only use :
optionLabel?: NestedKeyOf<TOption> | stringit wouldn't Autocomplete
Also see:
#3207 (comment)
Because the onChange Value Type depends on the
optionValueandoptionGroupChildrenProps they are now conditional types.More Info:
#3207 (comment)