Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: generic options support #3200

Closed
5 tasks done
melloware opened this issue Aug 28, 2022 · 7 comments · Fixed by #3199
Closed
5 tasks done

TypeScript: generic options support #3200

melloware opened this issue Aug 28, 2022 · 7 comments · Fixed by #3199
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Typescript Issue or pull request is *only* related to TypeScript definition

Comments

@melloware
Copy link
Member

melloware commented Aug 28, 2022 •
edited by ulasturann
Loading

Add generic typing to SelectItem type components:

  • cascadeselect.d.ts
  • dropdown.d.ts
  • listbox.d.ts
  • multiselect.d.ts
  • selectbutton.d.ts
@melloware melloware self-assigned this Aug 28, 2022
@melloware melloware added Core Team Issue or pull request has been *opened* by a member of Core Team Typescript Issue or pull request is *only* related to TypeScript definition labels Aug 28, 2022
@melloware melloware added this to the 8.5.0 milestone Aug 28, 2022
@melloware melloware linked a pull request Aug 28, 2022 that will close this issue
Fix #3200 Add Generics to Dropdown, Cascadeselect, Listbox, Multiselect, Selectbutton #3199
Merged
@melloware melloware mentioned this issue Aug 28, 2022
Merged
@melloware
Copy link
Member Author

@DerDorius make a comment on this ticket so I can assign it to you.

@melloware melloware assigned DariusRDev and unassigned melloware Aug 28, 2022
melloware pushed a commit that referenced this issue Aug 28, 2022
@DariusRDev
Fix #3200 Add Generics to Dropdown, Cascadeselect, Listbox, Multisele…
9c32470 
…ct, Selectbutton (#3199)

* DataTable/TreeTable: stricter generically typed API #2523
Added Generics for Dropdown.
Generics have to be also added in:
cascadeselect.d.ts
listbox.d.ts
multiselect.d.ts
selectbutton.d.ts

because of the SelectItemOptionsType

* #2523 Add Generics to Select Button

* #2523 select button generics

* #2523 Add Generics to CascadeSelect

* #2523 add generics to List Box

* #2523 Add Multiselect Generics
melloware added a commit that referenced this issue Aug 28, 2022
@melloware
Revert "Fix #3200 Add Generics to Dropdown, Cascadeselect, Listbox, M…
d12e65c 
…ultiselect, Selectbutton (#3199)"

This reverts commit 9c32470.
melloware added a commit that referenced this issue Aug 28, 2022
@melloware
Revert "Fix #3200 Add Generics to Dropdown, Cascadeselect, Listbox, M…
eb41a97 
…ultiselect, Selectbutton (#3199)" (#3201)

This reverts commit 9c32470.
@melloware melloware reopened this Aug 28, 2022
@melloware melloware removed this from the 8.5.0 milestone Aug 28, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 29, 2022
@melloware
Fix primefaces#3200 Add Generics to Dropdown, Cascadeselect, Listbox,…
08faf46 
… Multiselect, Selectbutton
@melloware melloware mentioned this issue Aug 29, 2022
Closed
@melloware melloware self-assigned this Aug 29, 2022
DariusRDev added a commit to DariusRDev/primereact that referenced this issue Aug 30, 2022
@DariusRDev
fixes primefaces#3200 Added Conditional Types to the Value of these
38c2ad5
DariusRDev added a commit to DariusRDev/primereact that referenced this issue Aug 30, 2022
@DariusRDev
primefaces#3200 fix NestedKeyOf Type
e96f737
@DariusRDev
Copy link
Contributor

So I added this:
#3207 (comment)
and this:
#3207 (comment)

But not for the Cascade Select, because of the Tree Shape of the Object

@DariusRDev DariusRDev mentioned this issue Aug 30, 2022
Closed
DariusRDev added a commit to DariusRDev/primereact that referenced this issue Aug 30, 2022
@DariusRDev
primefaces#3200 Fresh Branch with changes
7cc863c
@DariusRDev DariusRDev mentioned this issue Aug 30, 2022
Merged
DariusRDev added a commit to DariusRDev/primereact that referenced this issue Aug 30, 2022
@DariusRDev
primefaces#3200 revert copy error
6c6a7a8
@melloware melloware added this to the 8.6.0 milestone Sep 14, 2022
melloware added a commit that referenced this issue Sep 17, 2022
@melloware
Revert "fixes #3200 Add Generics to Dropdown, Listbox, Multiselect an…
dcd1d9e 
…d Selectbutton (#3212)"

This reverts commit da22a22.
@melloware melloware removed this from the 8.6.0 milestone Sep 17, 2022
@melloware melloware reopened this Sep 17, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 17, 2022
@melloware
Copy link
Member Author

Had to revert this it causes just too much chaos for people upgrading.

@melloware melloware reopened this Sep 17, 2022
@melloware melloware removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Core Team Issue or pull request has been *opened* by a member of Core Team labels Sep 17, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 17, 2022
@DariusRDev
Copy link
Contributor

So is this a dead end for typescript generics in Primereact?

I'd love better Autocomplete for PrimeReact Components.

@melloware
Copy link
Member Author

I don't think it's dead but when I tried to implement multiselect in my current app it complained I was missing 3 of 4 generics. Then when I started looking at it regular users are not going to be able to understand what they need to implement.

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 19, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Dec 3, 2023
@github-actions GitHub Actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
No milestone
2 participants
@melloware @DariusRDev