-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #3039 | FilterTemplate support for components #3071
Conversation
Docs need updating to show an example of filterTemplate usage |
@iantrudell a great way to get involved would be to submit a PR updating the docs |
Adding a feature to the library without documentation is not the correct behavior form a development team this is not the consumers responsibility in any capacity. This PR should have been denied without the documentation end of story What gems buried in history.... |
@muffinfaery you do know what Open Source is right? It means anyone can contribute and a great way for new people to get involved is to provide Documentation updates and PR's. So I am not sure what your point is? And the PR was from a PrimeTek employee so who was going to deny it? |
I'm glad you are encouraging helping and to build up folks involvement in the community. I simply find it strange that you suggest that an open source library with the backing of a member organization that reviews and merges commits as a team (even charges for some things, as they should) should not be responsible for its own quality. Fundamentally it sounds like you and I have different expectations when it comes to release ready features. I find the lack of documentation and constant requests for examples of features in the Primetek git issues to be a compelling reason for those to be wary of this library to solve their concerns when involving less capable or untrained developers. |
Understood, I get your points. But a few things to remember....
|
Add filterTemplate support for components.