Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeSelect: showClear attribute #4716

Closed
br-lemes opened this issue Aug 1, 2023 · 2 comments · Fixed by #4773
Closed

TreeSelect: showClear attribute #4716

br-lemes opened this issue Aug 1, 2023 · 2 comments · Fixed by #4773
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
10.0.0

Comments

@br-lemes
Copy link

br-lemes commented Aug 1, 2023

Describe the feature you would like to see added

It would be nice if there is showClear in TreeSelect as Dropdown. So that I can select a value or remove that value.

When used with checkbox, I can remove everything. But not for the basics.

This is a duplicate of #2973 which was closed with #3071

But I can't figure out how #3071 could solve this.

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@br-lemes br-lemes added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 1, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 1, 2023
@melloware
Copy link
Member

I think what he was referring to was you can put whatever you want in the filter but a ShowClear would be helpful here. I will add it.

@melloware melloware removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 1, 2023
@melloware melloware self-assigned this Aug 1, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 1, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 14, 2023
@melloware
Fix primefaces#4716: TreeSelect showClear and clearIcon
6a465e7
This was referenced Aug 14, 2023
Merged
Merged
melloware added a commit to melloware/primereact that referenced this issue Aug 14, 2023
@melloware
Fix primefaces#4716: TreeSelect showClear and clearIcon
9d9e856
melloware added a commit to melloware/primereact that referenced this issue Aug 14, 2023
@melloware
Fix primefaces#4716: TreeSelect showClear and clearIcon
8ffc9fe
melloware added a commit to melloware/primereact that referenced this issue Aug 14, 2023
@melloware
Fix primefaces#4716: TreeSelect showClear and clearIcon
12f1e83
melloware added a commit that referenced this issue Aug 14, 2023
@melloware
Fix #4716: TreeSelect showClear and clearIcon (#4773)
a8866ee 
* Fix #4716: TreeSelect showClear and clearIcon

* Fix #4716: TreeSelect showClear and clearIcon
@melloware
Copy link
Member

Theme fix submitted also: primefaces/primereact-sass-theme#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4716: TreeSelect showClear and clearIcon melloware/primereact
2 participants
@br-lemes @melloware