Fix #2671: Showcase store theme in local storage #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
added
the
Status: Pending Review
|
Hi @melloware, Could you please create a new issue about useStorage? We can add it. I'm waiting for feedback about the showcase issue from @cagataycivici . |
|
OK this PR rebased after the useStorageHook was merged |
|
This commit has been manually reverted for now as it causes hydration problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Fix #2671: Showcase store theme in local storage
Added new hook
useStoragewhich can be a drop in replacement for anywhere you useuseState. You can choosesessionorlocalstorage but it defaults tolocalstorage