Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showcase: Save theme setting in localStorage #2671

Closed
wolnynick opened this issue Mar 3, 2022 · 1 comment · Fixed by #2772
Closed

Showcase: Save theme setting in localStorage #2671

wolnynick opened this issue Mar 3, 2022 · 1 comment · Fixed by #2772
Assignees
@cagataycivici @melloware @mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.7.3

Comments

@wolnynick
Copy link 

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Hello, this bug is related only with your documentation page: https://primefaces.org/primereact/

Current behavior
When I go into your page and select for example: saga-blue, then its not saved for next browser session. It's always starts from lara-dark-indigo in my case.

Expected behavior
Please save chosen theme and then on start check if something is saved. Setting theme always based on user device settings is really annoying.
@melloware
Copy link
Member

@wolnynick people have complained on Discord about this too. @cagataycivici I think you mentioned you were going to fix this?

image

@yigitfindikli yigitfindikli added Type: New Feature Issue contains a new feature or new component request Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request labels Mar 31, 2022
@melloware melloware changed the title Annoying thing with theme settings in documentation Showcase: Save theme setting in localStorage Apr 15, 2022
@melloware melloware self-assigned this Apr 18, 2022
@melloware melloware added this to the 8.0.0-rc.3 milestone Apr 19, 2022
melloware added a commit to melloware/primereact that referenced this issue Apr 19, 2022
@melloware
Fix primefaces#2671: Showcase store theme in local storage
65db152
melloware added a commit to melloware/primereact that referenced this issue Apr 19, 2022
@melloware
Fix primefaces#2671: Showcase store theme in local storage
66bc802
@melloware melloware mentioned this issue Apr 19, 2022
Merged
@mertsincan mertsincan modified the milestones: 8.0.0.Final, 8.1.0 Apr 20, 2022
@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Apr 20, 2022
melloware added a commit to melloware/primereact that referenced this issue Apr 20, 2022
@melloware
Fix primefaces#2671: Showcase store theme in local storage
353159e
@mertsincan mertsincan modified the milestones: 8.2.0, Future Jul 6, 2022
melloware added a commit that referenced this issue Nov 10, 2022
@melloware
Fix #2671: Showcase store theme in local storage (#2772)
26e6c00 
* Fix #2671: Showcase store theme in local storage

* Fix #2671: Showcase store theme in local storage

* Update _app.js
@melloware melloware modified the milestones: Future, 8.7.3 Nov 10, 2022
@melloware melloware removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Nov 10, 2022
@melloware melloware mentioned this issue Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@melloware melloware

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #2671: Showcase store theme in local storage melloware/primereact
5 participants
@cagataycivici @melloware @mertsincan @yigitfindikli @wolnynick