Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: inputClassName doesn't work with Tailwind #5385

Closed
igo opened this issue Nov 23, 2023 · 1 comment · Fixed by #5386
Closed

Password: inputClassName doesn't work with Tailwind #5385

igo opened this issue Nov 23, 2023 · 1 comment · Fixed by #5386
Assignees
@melloware
Labels
Component: Tailwind Tailwind specific issue Type: Bug Issue contains a defect related to a specific component.
Milestone
10.2.0

Comments

@igo
Copy link

igo commented Nov 23, 2023

Describe the bug

inputClassName on Password doesnt seem to add classes. Use the demo at https://primereact.org/password/ theming, change:

<Password value={value} onChange={(e) => setValue(e.target.value)} inputClassName="asdfasdf"/>

class is not added

Reproducer

No response

PrimeReact version

10.1.1

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@igo igo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 23, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 23, 2023
@melloware
Copy link
Member

Definitely a bug. I will take a look.

melloware added a commit to melloware/primereact that referenced this issue Nov 23, 2023
@melloware
Fix primefaces#5385: Password inputClassname missing
6ba6f47
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Nov 23, 2023
@melloware melloware self-assigned this Nov 23, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 23, 2023
@melloware melloware mentioned this issue Nov 23, 2023
Merged
melloware added a commit that referenced this issue Nov 23, 2023
@melloware
Fix #5385: Password inputClassname missing (#5386)
a28c583
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5385: Password inputClassname missing
fe67639
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes2 (#5710)
24e22e0 
* Fix #5349: PanelMenu fix from PrimeVue

* Fix #5360: Cascade select popup not closing on escape

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5365 SplitButton popup not closing on escape button click

* Fix #5367: SpeedDial close on escape

* Fix #2666: Fix overlay components in cell editor

* Fix #5363: Mention better fix

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues

* Fix #5385: Password inputClassname missing

* Fix #5390: Calendar only render navigator in first month of multiple months

* Fix #5202: Calendar rendering performance increase

* Fix #5535: Calendar update input on locale change

* Fix #5533/#4147: Calendar respect viewDate

* Fix Calendar Input Docs

* fix:Calendar:currentView changed should invoke alignOverlay

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Tailwind Tailwind specific issue Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.2.0
Development

Successfully merging a pull request may close this issue.

Fix #5385: Password inputClassname missing melloware/primereact
2 participants
@igo @melloware