Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention: Page Breaks when navigating to Mention component #5363

Closed
akshayaqburst opened this issue Nov 21, 2023 · 2 comments · Fixed by #5364 or #5375
Closed

Mention: Page Breaks when navigating to Mention component #5363

akshayaqburst opened this issue Nov 21, 2023 · 2 comments · Fixed by #5364 or #5375
Assignees
@akshayaqburst
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.2.0

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Mention: Page Breaks when navigating to Mention component

Reproducer

No response

PrimeReact version

10.1.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Navigate to https://primereact.org/mention/
  2. Application breaks with console errors.

Expected behavior

The page should load when navigating to https://primereact.org/mention/
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2023
@akshayaqburst
Copy link
Contributor Author

akshayaqburst commented Nov 21, 2023 •
edited
Loading

@melloware I will work on this. Please give your PR suggestions if any and I can re-work on them. Please do not unassign items that I had already spent time on, like you did for some older issues.

akshayantony55 added a commit to qburst/primereact_qb17 that referenced this issue Nov 21, 2023
@akshayantony55
fix: primefaces#5363, Mention: Page Breaks when navigating to Mention…
8099c57 
… component
@akshayaqburst akshayaqburst mentioned this issue Nov 21, 2023
Merged
akshayantony55 added a commit to qburst/primereact_qb17 that referenced this issue Nov 21, 2023
@akshayantony55
fix: primefaces#5363, Mention: Page Breaks when navigating to Mention…
6afcdaf 
… component
akshayantony55 added a commit to qburst/primereact_qb17 that referenced this issue Nov 21, 2023
@akshayantony55
fix: primefaces#5363, Mention: Page Breaks when navigating to Mention…
249886c 
… component
@melloware
Copy link
Member

@akshayaqburst I appreciate your effort but I need to assign and unassign tickets as I see fit. Your solution to the other ticket was incorrect.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 21, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 21, 2023
melloware pushed a commit that referenced this issue Nov 21, 2023
@akshayaqburst @akshayantony55
fix: #5363, Mention: Page Breaks when navigating to Mention component (…
d4d5934 
…#5364)

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5363, Mention: Page Breaks when navigating to Mention component

---------

Co-authored-by: akshayantony55 <[email protected]>
@melloware melloware mentioned this issue Nov 22, 2023
Closed
melloware added a commit to melloware/primereact that referenced this issue Nov 22, 2023
@melloware
Fix primefaces#5363: Mention better fix
7322544
@melloware melloware mentioned this issue Nov 22, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Nov 22, 2023
@melloware
Fix primefaces#5363: Mention better fix
e055702
melloware added a commit that referenced this issue Nov 22, 2023
@melloware
Fix #5363: Mention better fix (#5375)
e286f3e
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
fix: primefaces#5363, Mention: Page Breaks when navigating to Mention…
21e6ac1 
… component
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5363: Mention better fix
4c1ff39
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes2 (#5710)
24e22e0 
* Fix #5349: PanelMenu fix from PrimeVue

* Fix #5360: Cascade select popup not closing on escape

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5365 SplitButton popup not closing on escape button click

* Fix #5367: SpeedDial close on escape

* Fix #2666: Fix overlay components in cell editor

* Fix #5363: Mention better fix

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues

* Fix #5385: Password inputClassname missing

* Fix #5390: Calendar only render navigator in first month of multiple months

* Fix #5202: Calendar rendering performance increase

* Fix #5535: Calendar update input on locale change

* Fix #5533/#4147: Calendar respect viewDate

* Fix Calendar Input Docs

* fix:Calendar:currentView changed should invoke alignOverlay

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.2.0
2 participants
@melloware @akshayaqburst