Fixed #730 - Incorrect column sortable prop type definition

primefaces · Jan 9, 2019 · 6c3942c · 6c3942c
1 parent 6a49274
commit 6c3942c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/datatable/DataTable.js b/src/components/datatable/DataTable.js
@@ -317,7 +317,7 @@ export class DataTable extends Component {
     sortSingle(data, sortField, sortOrder) {
         let value = [...data];
 
-        if(this.columnSortable && this.columnSortable === 'custom' && this.columnSortFunction) {
+        if(this.columnSortable && this.columnSortFunction) {
             value = this.columnSortFunction({
                 field: this.getSortField(),
                 order: this.getSortOrder()

diff --git a/src/showcase/datatable/DataTableDemo.js b/src/showcase/datatable/DataTableDemo.js
@@ -683,12 +683,12 @@ multiSortMeta.push({field: 'brand', order: -1});
 `}
 </CodeHighlight>
 
-            <p>To customize sorting algorithm, set sortable option to custom and define a sortFunction that sorts the list.</p>
+            <p>To customize sorting algorithm, define a sortFunction that sorts the list.</p>
 <CodeHighlight className="language-jsx">
 {`
 <DataTable value={this.state.cars} >
     <Column field="vin" header="Vin" sortable={true}/>
-    <Column field="year" header="Year" sortable="custom" sortFunction={this.mysort}/>
+    <Column field="year" header="Year" sortable={true} sortFunction={this.mysort}/>
     <Column field="brand" header="Brand" sortable={true}/>
     <Column field="color" header="Color" sortable={true}/>
 </DataTable>