Fixed #734 - DataTable edit throws error on route change

primefaces · Jan 9, 2019 · 6a49274 · 6a49274
1 parent 27af3ed
commit 6a49274
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/components/datatable/BodyCell.js b/src/components/datatable/BodyCell.js
@@ -110,6 +110,10 @@ export class BodyCell extends Component {
         }
     }
 
+    componentWillUnmount() {
+        this.unbindDocumentEditListener();
+    }
+
     render() {
         let content, header;
         let cellClassName = classNames(this.props.bodyClassName||this.props.className, {

diff --git a/src/sass/App.scss b/src/sass/App.scss
@@ -1184,6 +1184,12 @@ pre[class*="language-"] {
     padding-top: 0 !important;
 }
 
+.treetableedit-demo {
+    .p-treetable tr {
+        outline: 0 none;
+    }
+}
+
 /* FlexGrid Demos */
 .flexgrid-demo {
     .box,

diff --git a/src/showcase/treetable/TreeTableEditDemo.js b/src/showcase/treetable/TreeTableEditDemo.js
@@ -74,14 +74,14 @@ export class TreeTableEditDemo extends Component {
             <div>
                 <TreeTableSubmenu />
 
-                <div className="content-section introduction">
+                <div className="content-section introduction treetableeditdemo">
                     <div className="feature-intro">
                         <h1>TreeTable - Edit</h1>
                         <p>Incell editing provides a quick and user friendly way to manipulate data.</p>
                     </div>
                 </div>
 
-                <div className="content-section implementation">
+                <div className="content-section implementation treetableedit-demo">
                     <TreeTable value={this.state.nodes}>
                         <Column field="name" header="Name" expander style={{height: '3.5em'}}></Column>
                         <Column field="size" header="Size" editor={this.sizeEditor} editorValidator={this.requiredValidator} style={{height: '3.5em'}}></Column>