Fix #6520 - overlayPanel's and dialog's onHide #6534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call this.onOverlayHide in destructor only if it is visible. Revert previous onHide emitting interrupter.
Call this.onOverlayHide in destructor only if it is visible. Revert previous onHide emitting interrupter.
Update overlayPanel's onHide.
|
Please merge it, anybody ;( |
|
We'll handle it differently, I don't think it makes sense to call onHide at ondestroy e.g. route change. |
|
@cagataycivici are there any changes? because it looks like |
|
I think that makes sense to call onHide on destroy because sometimes you can have an ngIf in a component that have a dialog inside and if have some logic when de dialog disappears in this case this logic will not fired. Please reconsidere this pull request @cagataycivici |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Fix #6520 - overlayPanel's and dialog's onHide. Revert previous changes (PR #6471) and suspend calling onOverlayHide event in destructor if overlay is not visible.
###Feature Requests
N/A