Update overlayPanel and dialog. Emit onHide only if panel/dialog is visible. #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a panel on layout, subscription to onHide. Once we navigate to another form, onDestroy is triggered and then onHide is emmited, but it was not supposed to as dialog was not even shown.
|
Was reported in issue #6442 |
Dialog should not emit onHide if it wasn't shown
Hunroll
changed the title
|
Thank you. |
|
the variable isvisible is already set to false before onOverlayHide is being called, so this never get's executed |
|
Thank you! Created new PR to fix both problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
We have a panel on layout, subscription to onHide. Once we navigate to another form, onDestroy is triggered and then onHide is emmited, but it was not supposed to as dialog was not even shown.
###Feature Requests
N/A