Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeNG v18, p-datePicker with 'range' mode, doesn't work the property 'hideOnDateTimeSelect' #17222

Closed
1 of 4 tasks
ilFortu opened this issue Dec 26, 2024 · 1 comment · Fixed by #17385
Closed
1 of 4 tasks
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ilFortu
Copy link

ilFortu commented Dec 26, 2024

Describe the bug

As you can see here: https://stackblitz.com/edit/yskatmmp?file=src%2Fapp%2Fdatepicker-basic-demo.html
When the datePicker is used in 'range' mode and 'hideOnDateTimeSelect' is set to false it doesn't work properly, the 'false' setting is ignored and the panel is closed once selected the second date

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/yskatmmp?file=src%2Fapp%2Fdatepicker-basic-demo.html

Environment

Angular v18 and PrimeNG v18

Angular version

18.2.13

PrimeNG version

v18 (LTS Only)

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Check here https://stackblitz.com/edit/yskatmmp?file=src%2Fapp%2Fdatepicker-basic-demo.html

Expected behavior

hideOnDateTimeSelect should properly work with range mode, as it was in the previous PrimeNG versions.

@ilFortu ilFortu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 26, 2024
@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 26, 2024
@cetincakiroglu cetincakiroglu added this to the 19.0.3 milestone Dec 26, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 26, 2024
@tom-vism
Copy link

tom-vism commented Jan 7, 2025

Second that. The issue persists in 19.0.2. Here is the link to the older github issue describing the same problem as well as the proposed solution #14558

imaksp added a commit to imaksp/primeng that referenced this issue Jan 14, 2025
fix hideOnDateTimeSelect issue with range mode.
mertsincan pushed a commit that referenced this issue Jan 15, 2025
fix hideOnDateTimeSelect issue with range mode.
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 15, 2025
@mertsincan mertsincan modified the milestones: 19.1.0, 19.0.6 Jan 15, 2025
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants