p-calendar: Doesn't close on date selection in range mode

[lm-swaroop]

Describe the bug

hideOnDateTimeSelect doesn't work when selectionMode="range"

Environment

Chrome Version 120.0.6099.109
Ubuntu 22.04

Reproducer

https://stackblitz.com/edit/cte5uw?file=src%2Fapp%2Fdemo%2Fcalendar-range-demo.html

Angular version

17.0.0

PrimeNG version

17.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Chrome 120

Steps to reproduce the behavior

1. Select start date
2. Select end date

Expected behavior

Datepicker overlay should close

[mertsincan]

Thanks a lot for your report! We'll check and get back to you.

[amonsour]

Sorry to open this back up, but now the hideOnDateTimeSelect does not do anything if range is selected.
Should add && this.hideOnDateTimeSelect at the end for those who want the Calendar to stay open:

primeng/src/app/components/calendar/calendar.ts

Line 1495 in 27065cf

if ((this.isSingleSelection() && this.hideOnDateTimeSelect) || (this.isRangeSelection() && this.value[1])) {

[Xylios13]

Due to this change, as @amonsour mentioned, the property hideOnDateTimeSelect is no longer respected when in range selection mode.

Please take a look at this :)

[cetincakiroglu]

This issue is closed by a typo of another PR comment. Re-opening the issue

[cetincakiroglu]

Hi,

Couldn't replicate the same behavior in the latest version (17.11.0) https://stackblitz.com/edit/cte5uw-mrpz6a?file=package.json

This issue was probably solved with a PR of another issue between versions 17.0.0 and 17.11.0 . Closing the issue since it doesn't exist anymore.