Fix broken cli tests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
May 18, 2017
| @@ -49,7 +53,7 @@ module.exports = { | |||
| }, | |||
| validate: { | |||
| description: 'This runs several scripts to make sure things look good before committing or on clean install', | |||
| script: concurrent.nps('lint', 'build', 'test'), | |||
| script: concurrent.nps('lint', 'build', 'test', 'test.cli'), | |||
There was a problem hiding this comment.
Oh! Nice! I had no idea we weren't running those! 😅 thank you!
|
Hmmm... Looks like the tests don't pass on travis. |
BenoitZugmeyer
force-pushed
the
fix-broken-cli-tests
branch
from
055113f to
f383198
Compare
|
Sorry I edited the first commit to make sure the prettier-eslint output isn't printing colors. But it seems it still doesn't work on travis... I'm on it. |
BenoitZugmeyer
force-pushed
the
fix-broken-cli-tests
branch
from
f383198 to
72ea572
Compare
In order to make sure the prettier-eslint command won't display colored output, we have to tweak the environment variables. We don't want colored output because it won't match jest snapshots.
In prettier#54 I removed the extra new line at the end of files printed to stdout. I wasn't aware of cli-tests, so I didn't change those. This commit adjust the expected output of files formated and printed to stdout.
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 97 97
=====================================
Hits 97 97Continue to review full report at Codecov.
|
|
Finally! I really hate |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: The CLI tests are failing since #54.
Why: #54 changes the output of files printed to stdout, but didn't change the expected output in the tests.
How: Fixed by adjusting the expected output + adding CLI tests to the CI.