fix(stdout): remove extra newlines at EOF #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using console.log, an extra newline is printed after the code formated by prettier/eslint. See related prettier issue prettier/prettier#437 Fix prettier#51
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 90 90
=====================================
Hits 90 90
Continue to review full report at Codecov.
|
BenoitZugmeyer
added a commit
to BenoitZugmeyer/prettier-eslint-cli
that referenced
this pull request
May 18, 2017
In prettier#54 I removed the extra new line at the end of files printed to stdout. I wasn't aware of cli-tests, so I didn't change those. This commit adjust the expected output of files formated and printed to stdout.
Merged
BenoitZugmeyer
added a commit
to BenoitZugmeyer/prettier-eslint-cli
that referenced
this pull request
May 18, 2017
In prettier#54 I removed the extra new line at the end of files printed to stdout. I wasn't aware of cli-tests, so I didn't change those. This commit adjust the expected output of files formated and printed to stdout.
BenoitZugmeyer
added a commit
to BenoitZugmeyer/prettier-eslint-cli
that referenced
this pull request
May 18, 2017
In prettier#54 I removed the extra new line at the end of files printed to stdout. I wasn't aware of cli-tests, so I didn't change those. This commit adjust the expected output of files formated and printed to stdout.
kentcdodds
pushed a commit
that referenced
this pull request
May 18, 2017
* feat(tests): run cli-tests in CI In order to make sure the prettier-eslint command won't display colored output, we have to tweak the environment variables. We don't want colored output because it won't match jest snapshots. * fix(tests): adjust expected output for stdout cli tests In #54 I removed the extra new line at the end of files printed to stdout. I wasn't aware of cli-tests, so I didn't change those. This commit adjust the expected output of files formated and printed to stdout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using console.log, an extra newline is printed after the code formated by prettier/eslint. See
related prettier issue prettier/prettier#437
Fix #51