Refactor type unification code #4131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares Presto for lambda support which requires more powerful type unification.
|
It would be nice if this one gets in after #4005 and Teradata#88. cc: @pnowojski |
| import static com.google.common.collect.Iterables.getOnlyElement; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public final class TypeUnification |
There was a problem hiding this comment.
I would very much like to see tests here.
This code support more usecases than currently accessible using SQL query syntax.
And without UT it is hard to be sure those usecases actually work.
|
@losipiuk yes, that's my current plan. I'm working my way through the other pull requests now. |
ghost
added
the
|
Closing for now, since @haozhun is working a new implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares Presto for lambda support which requires more powerful type unification.