Refactor type unification code #3409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Coercion rules were duplicated in the original code (and diverged). The rules appear only once in the code after this commit. * Coercion between types with type parameters (e.g. array<T> and array<U>) could be arbitrary and potentially complex. After this commit, coercibility between types is decoupled from compatibility between type parameters.
|
|
||
| private HashMap<T, Entry> map = new HashMap<>(); | ||
|
|
||
| private boolean union(T root1, T root2) |
|
Do I read it correctly that this is a POC? |
| } | ||
| else if (rightVs != null) { | ||
| leftVs.addAll(rightVs); | ||
| map.remove(leftVs); |
|
@sopel39, yes, was the result of a hackathon project. |
Merged
|
Superceded by #4131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit refactors getCommonSuperType and canCoerce:
The second commit refactors type unification code to make it more flexible so that it can be extended to support more complex use cases (lambda).