Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed visualize.py to python 3 #247

Merged
merged 2 commits into from
Jan 2, 2022

Conversation

mohamad-altaweel
Copy link
Contributor

@mohamad-altaweel mohamad-altaweel commented Dec 31, 2021

In Python 3, there is no xrange, but the range function behaves like xrange in Python 2. If you want to write code that will run on both Python 2 and Python 3, you should use range().

https://www.geeksforgeeks.org/range-vs-xrange-python/

Resolves #235 ,

@IshaanDesai IshaanDesai self-requested a review January 2, 2022 14:24
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this 👍

@IshaanDesai IshaanDesai merged commit 3d17693 into precice:develop Jan 2, 2022
@davidscn davidscn linked an issue Jan 3, 2022 that may be closed by this pull request
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partitioned-elastic-beam: Visualization script is still in Python 2
3 participants