Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partitioned-elastic-beam: Visualization script is still in Python 2 #235

Closed
MakisH opened this issue Sep 15, 2021 · 2 comments · Fixed by #247
Closed

partitioned-elastic-beam: Visualization script is still in Python 2 #235

MakisH opened this issue Sep 15, 2021 · 2 comments · Fixed by #247
Assignees
@mohamad-altaweel
Labels
good first issue Good for newcomers
Milestone
v202202.0

Comments

@MakisH
Copy link
Member

MakisH commented Sep 15, 2021

File: https://github.com/precice/tutorials/blob/6d90ae3eb179113beb400e472c8832e29a48db9b/partitioned-elastic-beam/visualize.py

With a quick look, the print needs parentheses. After fixing this, Python complains about xrange. Maybe there are a few more.
@MakisH MakisH added the good first issue Good for newcomers label Sep 15, 2021
@mohamad-altaweel mohamad-altaweel mentioned this issue Dec 31, 2021
Merged
@mohamad-altaweel
Copy link
Contributor

we can close the issue right now

@davidscn davidscn linked a pull request Jan 3, 2022 that will close this issue
changed visualize.py to python 3 #247
Merged
@davidscn
Copy link
Member

davidscn commented Jan 3, 2022

Thanks @mohamad-altaweel

@davidscn davidscn closed this as completed Jan 3, 2022
@MakisH MakisH added this to the v202102.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamad-altaweel mohamad-altaweel

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v202202.0
Development

Successfully merging a pull request may close this issue.

changed visualize.py to python 3 mohamad-altaweel/tutorials
3 participants
@MakisH @davidscn @mohamad-altaweel