Fix code highlighting and linting errors #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
muuki88
commented
Jun 19, 2023
| <script src="{{site.baseurl}}/assets/js/jquery.min.js"></script> | ||
| <script src="{{site.baseurl}}/assets/js/docs.min.js"></script> | ||
| <script src="{{site.baseurl}}/assets/js/easing.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js" integrity="sha384-ho+j7jyWK8fNQe+A12Hb8AhRq26LrZ/JpcUGGOn+Y7RsweNrtN/tE3MoK7ZeZDyx" crossorigin="anonymous"></script> | ||
| <script src="{{site.baseurl}}/assets/js/main.js"></script> | ||
| <script type="text/javascript" src="{{site.baseurl}}/assets/js/pbjs_home.js"></script> | ||
| <script type="text/javascript" src="/assets/js/video/pb-code-highlight.js"></script> |
There was a problem hiding this comment.
A second code highlighting for no reason
muuki88
commented
Jun 19, 2023
| @@ -34,13 +34,12 @@ | |||
| <link href="{{site.baseurl}}/assets/images/apple-touch-icon.png" rel="apple-touch-icon"> | |||
|
|
|||
|
|
|||
| <script src="{{site.baseurl}}/assets/js/prism.js"></script> | |||
There was a problem hiding this comment.
should only be loaded once in the footer. This also speeds up rendering the page
muuki88
commented
Jun 19, 2023
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@docsearch/css@3" /> | ||
| <link href="{{site.baseurl}}/assets/css/prism.css" rel="stylesheet" /> |
|
Apparently this only fixed code highlighting in the preview deployment and locally. The github pages html served is still missing the CSS and delivers the outdated JS. |
ecdrsvc
pushed a commit
to ecdrsvc/prebid.github.io
that referenced
this pull request
Sep 6, 2023
* fix examples markdown lint errors * Fix partners.md * Fix code hightlighting * Fix some linting errors in prebid-mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code highlighting, update prism.js and load pism.css.
Relates to