Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown lint step #4646

Merged
merged 11 commits into from
Jun 19, 2023
Merged

Add markdown lint step #4646

merged 11 commits into from
Jun 19, 2023

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Jun 15, 2023

Adding https://github.com/igorshubovych/markdownlint-cli into the CI pipeline to ensure a consistent markdown style and catch broken anchors early on.

builds on top of #4620

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit adb05de
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/64902d8c2d7ed80008fcbed6
😎 Deploy Preview https://deploy-preview-4646--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@muuki88
Copy link
Contributor Author

muuki88 commented Jun 19, 2023

@bretg I'll merge this. The current way I would start enforcing this, is to remove more and more folders from the .markdownignoreignore and fixing the issues in upcoming pull requests.

@muuki88 muuki88 merged commit 52337d0 into master Jun 19, 2023
@muuki88 muuki88 deleted the markdownlint-build-step branch June 19, 2023 10:33
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Add markdown lint step

* Fix a lot of tabs and code hightlighs

* Replace cross-player-communication html with markdown

* Add markdownlintignore and batch of fixes

* Use markdownlint-cli directly

* Correct docker image version

* Add missing markdownlint param

* Run markdownlint --fix

* Fix bunch of linting errors and ignore dev-docs

* Add description about markdownlint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant