Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin Google Play Services Ads to 22.6.0 #741

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: Pin Google Play Services Ads to 22.6.0 #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Example/PrebidDemoJava/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ dependencies {
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'

// Ads
implementation 'com.google.android.gms:play-services-ads:+'
implementation libs.google.play.services.ads

// Video Player
implementation 'com.google.android.exoplayer:exoplayer:2.15.1'
Expand Down
2 changes: 1 addition & 1 deletion Example/PrebidDemoKotlin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dependencies {
implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1'

// Advertisement
implementation 'com.google.android.gms:play-services-ads:+'
implementation libs.google.play.services.ads
implementation "com.applovin:applovin-sdk:11.5.3"
implementation "com.google.android.gms:play-services-ads-identifier:18.0.1" // For Applovin Max

Expand Down
2 changes: 1 addition & 1 deletion Example/PrebidInternalTestApp/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ dependencies {

// Ad dependencies
implementation 'com.google.android.gms:play-services-base:18.1.0'
implementation 'com.google.android.gms:play-services-ads:+'
implementation libs.google.play.services.ads
implementation "com.applovin:applovin-sdk:11.3.2"
implementation "com.google.android.gms:play-services-ads-identifier:18.0.1" // For Applovin Max

Expand Down
2 changes: 1 addition & 1 deletion PrebidMobile/PrebidMobile-admobAdapters/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ android {

dependencies {
implementation project(":PrebidMobile")
implementation 'com.google.android.gms:play-services-ads:+'
implementation libs.google.play.services.ads
}
2 changes: 1 addition & 1 deletion PrebidMobile/PrebidMobile-gamEventHandlers/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ android {

dependencies {
implementation project(":PrebidMobile")
implementation 'com.google.android.gms:play-services-ads:+'
implementation libs.google.play.services.ads
}
3 changes: 2 additions & 1 deletion ...entHandlers/src/test/java/org/prebid/mobile/eventhandlers/global/GoogleAdVersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ public void checkIfLastVersionUsed() {
assertEquals(
"Google Ad SDK was updated to " + currentVersion + "! " +
"Please test Prebid SDK with the new version, resolve compilation problems, rewrite deprecated code. " +
"After testing you must update PrebidMobile.TESTED_GOOGLE_SDK_VERSION" +
"After testing you must update PrebidMobile.TESTED_GOOGLE_SDK_VERSION," +
"update google-play-services-ads version on the libs.versions.toml " +
"and also must update version in publishing XML files (scripts/Maven/*.xml.",
currentVersion,
PrebidMobile.TESTED_GOOGLE_SDK_VERSION
Expand Down
5 changes: 5 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[versions]
google-play-services-ads = "22.6.0"

[libraries]
google-play-services-ads = { group = "com.google.android.gms", name = "play-services-ads", version.ref = "google-play-services-ads" }