Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin Google Play Services Ads to 22.6.0 #741

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

shinwan2
Copy link
Contributor

Summary

This fixes the build failure when building PrebidDemoKotlin for example. Below is the failure log

Manifest merger failed : uses-sdk:minSdkVersion 19 cannot be smaller than version 21 declared in library [com.google.android.gms:play-services-ads:23.0.0] /Users/shinwan2/.gradle/caches/transforms-3/81f307a4ec7ff1c69519d0f953072760/transformed/jetified-play-services-ads-23.0.0/AndroidManifest.xml as the library might be using APIs not available in 19
  Suggestion: use a compatible library with a minSdk of at most 19,
    or increase this project's minSdk version to at least 21,
    or use tools:overrideLibrary="com.google.android.gms.ads.impl" to force usage (may lead to runtime failures)

This is because the version was not pinned

implementation 'com.google.android.gms:play-services-ads:+'

and Google has released version 23.0.0 on 2024-03-07 which changes the minimum Android API level to 21 while Prebid still requires minimum API level 19.

I use version catalog to centralize the constant. Let me know if a naming convention for that exists.

Test

Run the demo app.

Using 23.0.0 will fail the build because it requires minimum SDK 21 while Prebid still supports minimum SDK 19.
@jsligh jsligh self-requested a review March 22, 2024 15:32
@jsligh
Copy link
Collaborator

jsligh commented Mar 22, 2024

This solves the problem currently but this issue needs to be further researched / addressed: #744

Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily solves the issue but see linked issue for future things for us to work on.

@jsligh jsligh merged commit 96cf676 into prebid:master Mar 22, 2024
@shinwan2 shinwan2 deleted the fix/demo-app-build-failure branch March 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants