NetworkOnMainThreadException Fix #734
Conversation
…to after destroy() was called.
…to after destroy() was called.
…prebid-mobile-android into 673-memory-leak-detected
Run getGlobalVisibleRect on the main thread instead of a background thread
Fixing Memory Leak
Release 2.2.0
...le-core/src/main/java/org/prebid/mobile/rendering/networking/modelcontrollers/Requester.java
Outdated
Show resolved
Hide resolved
| * This Async task is needed because the networkTask needs to be cancelled / destroyed | ||
| * on a background thread or it throws a NetworkOnMainThreadException | ||
| **/ | ||
| private static class DestroyNetworkTaskAsyncTask extends AsyncTask<BaseNetworkTask, Void, Void> { |
There was a problem hiding this comment.
I meant that DestroyNetworkTaskAsyncTask doesn't have much sense since it just helps to make a call to the thread not from the main thread, but still, it is not correct interprocess communication that may lead to unexpected behavior.
The networkTask.cancel(true) should do all the job.
There was a problem hiding this comment.
Can we try to remove the DestroyNetworkTaskAsyncTask at all? As for me, it just adds one more multithread call but doesn't influence the general behavior. networks.cancel(true) should stop the thread gracefully without direct communication with the network layer so the error should not appear.
The error in the initial ticket appears due to the networkTask.destroy(); call wich triggers the network communication on the main thread.
Using 23.0.0 will fail the build because it requires minimum SDK 21 while Prebid still supports minimum SDK 19.
fix: Pin Google Play Services Ads to 22.6.0
877 Arbitrary Open RTB Params
| * This Async task is needed because the networkTask needs to be cancelled / destroyed | ||
| * on a background thread or it throws a NetworkOnMainThreadException | ||
| **/ | ||
| private static class DestroyNetworkTaskAsyncTask extends AsyncTask<BaseNetworkTask, Void, Void> { |
There was a problem hiding this comment.
Can we try to remove the DestroyNetworkTaskAsyncTask at all? As for me, it just adds one more multithread call but doesn't influence the general behavior. networks.cancel(true) should stop the thread gracefully without direct communication with the network layer so the error should not appear.
The error in the initial ticket appears due to the networkTask.destroy(); call wich triggers the network communication on the main thread.
…ationbanneradunit' of https://github.com/prebid/prebid-mobile-android into 678-2-networkonmainthreadexception-when-destroying-mediationbanneradunit
jsligh
deleted the
678-2-networkonmainthreadexception-when-destroying-mediationbanneradunit
branch
Closes #678