Fix prebid timeout editable #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public should be the field timeoutMillis so it could be changed if needed from the publisher code when integrating the SDK: "PrebidMobile.timeoutMillis = 1000;" I removed public for the var "TIMEOUT_MILLIS" which is final so public is useless.
Closed
theAtheA
approved these changes
Jun 19, 2019
theAtheA
previously approved these changes
Jun 19, 2019
|
@yoalex5 , for review. Thanks, |
|
@ppuviarasu , can you please review this PR? Thanks, |
yoalex5
previously approved these changes
Jun 26, 2019
There was a problem hiding this comment.
@AntoineJac, thank you for contributing
This PR looks good for me.
I think we should have the same logic for iOS
PrebidMobile/API1.0/src/main/java/org/prebid/mobile/PrebidMobile.java
Outdated
Show resolved
Hide resolved
avohraa
reviewed
Jul 15, 2019
PrebidMobile/API1.0/src/main/java/org/prebid/mobile/PrebidMobile.java
Outdated
Show resolved
Hide resolved
avohraa
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public should be the field timeoutMillis so it could be changed if needed from the publisher code when integrating the SDK:
"PrebidMobile.timeoutMillis = 1000;"
I removed public for the var "TIMEOUT_MILLIS" which is final so public is useless.
Issue #111
API
Example