Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot set timeout #111

Closed
theAtheA opened this issue Jun 18, 2019 · 4 comments
Closed

cannot set timeout #111

theAtheA opened this issue Jun 18, 2019 · 4 comments
Assignees

Comments

@theAtheA
Copy link

In the pre 1.0 client version there was a way to set the client timeout. In the current version there is no public api to override/set the timeout. Could you please reintroduce this feature.
The PrebidMobile class already contains a timeout feature, but it's not public.

@bszekely1
Copy link
Contributor

Hi @theAtheA, I will bring this topic back up within the Prebid org. This was talked about some time ago and it may warrant further discussion.

@AntoineJac
Copy link
Contributor

@theAtheA , indeed the field should be public. I guess a small typo as be made as public is used for the variable which is useless as also declared as final. Here is the PR for the fix: #112

For information you can use below code as workaround:

    try {
        Field timeoutMillisField = PrebidMobile.class.getDeclaredField("timeoutMillis");
        timeoutMillisField.setAccessible(true);
        timeoutMillisField.set(null, 3000);
    } catch (NoSuchFieldException e) {
        e.printStackTrace();
    } catch (IllegalAccessException e) {
        e.printStackTrace();
    }

@theAtheA
Copy link
Author

Hi @theAtheA, I will bring this topic back up within the Prebid org. This was talked about some time ago and it may warrant further discussion.

As a note: My colleage requested the reimplementation for the same feature in the iOS sdk and it was already discussed and implemented there.

@bszekely1 bszekely1 self-assigned this Jun 27, 2019
@bszekely1
Copy link
Contributor

This will be released in 1.2

@bszekely1 bszekely1 added this to the Prebid SDK 1.2 milestone Jul 22, 2019
@yoalex5 yoalex5 closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants