Issue 329: CRD apiVersion check

[lspecian-olx]

Change log description

• Add the capability to install the chart in eks versions that don't support apiVersion=apiextensions.k8s.io/v1beta1 anymore

Purpose of the change

Closes #329

What the code does

The code is using .Capabilities.APIVersions.Has to check for the apiVersion apiextensions.k8s.io/v1, if it finds it it uses to create the CRD, if it doesn't it falls back to apiextensions.k8s.io/v1beta1

How to verify it

You are able to install the chart with the CRD in eks v1.19.0 version from which apiextensions.k8s.io/v1beta1 was removed

[codecov-commenter]

Codecov Report

Merging #330 (b2c9c4d) into master (a99c93b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files          11       11           
  Lines        1312     1312           
=======================================
  Hits         1111     1111           
  Misses        133      133           
  Partials       68       68           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99c93b...b2c9c4d. Read the comment docs.

[anishakj]

@lspecian-olx Thanks for the contribution. Do we need similar check here as well https://github.com/lspecian-olx/zookeeper-operator/blob/issue-329-crd-apiversion-check/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L3 ?

[lspecian-olx]

@lspecian-olx Thanks for the contribution. Do we need similar check here as well https://github.com/lspecian-olx/zookeeper-operator/blob/issue-329-crd-apiversion-check/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L3 ?

Indeed we need a similar check as well, I made a new commit including the change

[anishakj]

@lspecian-olx could you please address the review comment?

[anishakj]

LGTM

[SrishT]

LGTM

[anishakj]

@lspecian-olx when i tried to install Operator on a cluster with v1.19.9 version, got the below error. Are you also seeing same?

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "additionalPrinterColumns" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "subresources" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "validation" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]

[lspecian-olx]

@lspecian-olx when i tried to install Operator on a cluster with v1.19.9 version, got the below error. Are you also seeing same?

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "additionalPrinterColumns" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "subresources" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "validation" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]

Yes, I'm also seeing the same, preparing a PR with a fix for the issue #338