Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions.k8s.io/v1beta1 apiVersion removed on k8s v1.19.0 #329

Closed
lspecian-olx opened this issue May 19, 2021 · 0 comments · Fixed by #330
Closed

apiextensions.k8s.io/v1beta1 apiVersion removed on k8s v1.19.0 #329

lspecian-olx opened this issue May 19, 2021 · 0 comments · Fixed by #330

Comments

@lspecian-olx
Copy link
Contributor

Description

The apiextensions.k8s.io/v1beta1 apiVersion used in the CustomResourceDefinition was removed on k8s v1.19.0

Importance

The issue is a blocker to install the chart properly on k8s clusters with version v1.19.0

Location

https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/zookeeper.pravega.io_zookeeperclusters_crd.yaml#L2

Suggestions for an improvement

I suggest the issue should be fixed by checking the apiVersion with .Capabilities.APIVersions.Has

{{- if .Capabilities.APIVersions.Has "apiextensions.k8s.io/v1" }}
apiVersion: apiextensions.k8s.io/v1
{{- else }}
apiVersion: apiextensions.k8s.io/v1beta1
{{- end }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant