Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 291: Fixing post-install-upgrade hook #293

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jan 20, 2021

Signed-off-by: SrishT [email protected]

Change log description

The post-install-upgrade hook in zookeeper cluster charts currently does not verify that all desired replicas have been deployed.

Purpose of the change

Fixes #291

What the code does

The hook compares that the number of ready replicas is equal to the replica count mentioned within the spec, i.e. it checks that .status.readyReplicas == .spec.replicas

How to verify it

The zookeeper cluster deployment should succeed only when all the desired replicas have come to ready state.

@codecov-io
Copy link

Codecov Report

Merging #293 (1d0e1cb) into master (e393d1f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files          11       11           
  Lines        1258     1258           
=======================================
  Hits         1066     1066           
  Misses        129      129           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e393d1f...1d0e1cb. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit b50eaa4 into master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZK cluster post-install-upgrade hook does not wait for all replicas
3 participants