Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZK cluster post-install-upgrade hook does not wait for all replicas #291

Closed
jkhalack opened this issue Jan 15, 2021 · 0 comments · Fixed by #293
Closed

ZK cluster post-install-upgrade hook does not wait for all replicas #291

jkhalack opened this issue Jan 15, 2021 · 0 comments · Fixed by #293

Comments

@jkhalack
Copy link
Contributor

Description

The post-install-upgrade hook in zookeeper cluster chart does verify that all desired replicas have been deployed.
Since it checks for status.replicas == status.readyReplicas, the hook might pass, for example, when only two of three desired replicas have been deployed successfully, before the third replica even started creating.

Importance

should-have

Location

https://github.com/pravega/zookeeper-operator/blob/v0.2.9/charts/zookeeper/templates/post-install-upgrade-hooks.yaml#L66

Suggestions for an improvement

The hook should rather use spec.replicas in the check instead of status.replicas, so that the number of ready replicas is compared to the desired number of replicas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant