Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding checks to helm charts #248

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Adding checks to helm charts #248

merged 6 commits into from
Sep 23, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Sep 22, 2020

Signed-off-by: SrishT [email protected]

Change log description

Adds the necessary checks to the zookeeper charts in order to set values for a subset of the options provided within a given block.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #248 into master will increase coverage by 3.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   80.05%   83.36%   +3.30%     
==========================================
  Files          11       11              
  Lines        1118     1118              
==========================================
+ Hits          895      932      +37     
+ Misses        159      125      -34     
+ Partials       64       61       -3     
Impacted Files Coverage Δ
pkg/zk/generators.go 99.10% <0.00%> (+0.89%) ⬆️
...er/zookeepercluster/zookeepercluster_controller.go 60.39% <0.00%> (+0.99%) ⬆️
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go 100.00% <0.00%> (+18.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28c3d1...6cc6ffb. Read the comment docs.

@SrishT SrishT marked this pull request as ready for review September 22, 2020 17:16
SrishT added 5 commits September 23, 2020 03:45
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
charts/zookeeper/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -36,7 +36,7 @@ The operator itself is built with the [Operator framework](https://github.com/op

## Usage

We recommend using our [helm charts](charts) for all installation and upgrades. Since version 0.2.8 onwards, the helm charts for zookeeper operator and zookeeper cluster are published in [https://charts.pravega.io/](https://charts.pravega.io/). To add this repository to your Helm repos, use the following command
We recommend using our [helm charts](charts) for all installation and upgrades. Since version 0.2.8 onwards, the helm charts for zookeeper operator and zookeeper cluster are published in [https://charts.pravega.io](https://charts.pravega.io/). To add this repository to your Helm repos, use the following command
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we callout the helm rollback limitation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollbacks are supported in the pravega operator and not in the zookeeper operator currently. I will add that note in the Readme in the pravega operator documentation.

@anishakj anishakj merged commit 42f0f90 into master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants