Issue150: Helm chart should allow watch namespace to be passed in. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
amuraru
reviewed
Mar 29, 2020
| - "*" | ||
| verbs: | ||
| - '*' |
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 6 6
Lines 952 952
=======================================
Hits 456 456
Misses 467 467
Partials 29 29 Continue to review full report at Codecov.
|
|
Closing this PR as invalid, as the changes are messed up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj [email protected]
Change log description
Configured WATCH_NAMESPACE field in Helm charts.
Purpose of the change
Fixes #150
What the code does
Added new configuration param in values.yaml file, so that WATCH_NAMESPACE can be configured. Added new cluster roles in zookeeper-operator charts so that it can install zookeeper in different name space ,other than the one in which operator is running.
How to verify it
Tried installing operator and zk in same and different namespace using charts.