Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync helm chart RBAC with generated files #133

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Mar 5, 2020

Helm ClusterRole rules were out of date with the files generated in deploy.

@codecov-io
Copy link

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   47.84%   47.84%           
=======================================
  Files           6        6           
  Lines         951      951           
=======================================
  Hits          455      455           
  Misses        467      467           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ddb6e...9d2ee7e. Read the comment docs.

@amuraru
Copy link
Contributor Author

amuraru commented Mar 17, 2020

@spiegela Aaron - any chance we get this reviewed? Thanks

@pbelgundi pbelgundi requested a review from anishakj March 19, 2020 05:29
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbelgundi pbelgundi merged commit 6899194 into pravega:master Mar 30, 2020
@amuraru amuraru deleted the patch-1 branch May 21, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants