Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate with files and URIs on windows #27001
Associate with files and URIs on windows #27001
Changes from 10 commits
498d93b
0357882
2bac09e
cdcf5bd
2f42112
01efd1b
7789cc0
4ec9d26
0168ade
17033e0
57d5717
eeba937
f9d257b
0563507
6bdb076
738c287
ffdefbc
da8c454
7f5dedc
3419b8f
139072f
bf47221
8049270
7864810
dfa0c51
1dc54d6
6ded79c
6dbba70
f280747
9b3ec64
87509fb
61cc5d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit veiled, but what this ends up implying is that every single change of user language, or even the "show metadata in original language" toggle in settings, is going to cause writes to the windows registry. I am not comfortable with this and do not think that is sane.
I think there are two paths I'd rather take here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relies too heavily on the automatic language selection being correct. How about updating the localised description once the user selects and confirms their language in the first-run setup wizard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "too heavily"? I'm not sure I've known that to fail that much. If there's one place where that should work perfectly it's windows.
Eeeeehhhh I don't know. I'd rather not touch the registry outside of squirrel flows / manual intervention via settings button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppy/team-client I'm happy with the code and this PR is ready for review. The above conversation and stable in 'open with' remain the only open questions.