Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate with files and URIs on windows #27001

Merged
merged 32 commits into from
Mar 1, 2024

Fix typos in xmldoc

61cc5d6
Select commit
Loading
Failed to load commit list.
Merged

Associate with files and URIs on windows #27001

Fix typos in xmldoc
61cc5d6
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-03-01 03:26:29 ago

1 / 2 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
Supersedes #26658 Incomplete
Closes #14824 Incomplete
URL associations are implemented Incomplete
added localisable file descriptions Incomplete
added file icons Incomplete
registry keys are properly disposed Incomplete
implementation is testable in a reasonable way Incomplete
SHChangeNotify is now called in a non-blocking way Incomplete
fixed stable registry keys taking priority (this is handled by the windows explorer -- it'll ask the user (once) in which program to open) Incomplete
(Fixed) associations are re-created every time on startup (it's not great, but it probably doesn't matter that much) Completed
if stable uses HKEY_LOCAL_MACHINE, maybe we could use that there instead. since this PR saves to HKEY_CURRENT_USER Incomplete
localised file association descriptions are never written Incomplete
stable registers .osz2, is this a file format lazer can handle? (a quick search yields that it doesn't) Incomplete
stable uses a lowercase osu! beatmap as the file description Incomplete
stable calls every file osu! beatmap Incomplete
uninstalling lazer will restore stable as the protocol handler Incomplete
we can use the osu! entry for getStableInstallPathFromRegistry(), as that is used exclusively by stable Incomplete
not bother with localising descriptions at all Incomplete
localise them, but on a one-shot basis, at point of installation. Incomplete