Improvements for the mania editor

[smoogipoo]

Here's some feedback that was provided to me over the course of COE (and a little afterwards) pertaining to the editor. Some of it (especially around the timing screen) are more general usability concerns.

Timeline

Preview Give feedback

1. The notes cover the timeline, which hides the waveform. Having a way to see where notes are placed throughout the whole song would be nice however.
2. Timeline doesn't show SV markers
3. Not possible to go to 1/5th, 1/7th or 1/9th snaps in beat snap panel. It does work after I changed it to 1/5th, 1/7th or 1/9th with shortcut (Shift + 5)
4. Make the waveform more prominent/relevant to the playfield (e.g. similar to the etterna editor).

Setup

Preview Give feedback

1. Background does not show the file name of the current image used
2. Audio Track does not show the file name of the current audio used
3. Support reading beatmap metadata from ID3 tags in editor #21189
   area:editor osu!framework issue +2
4. It is not clear what gamemode is selected (It was on mania for me but wasn't clear why it was on mania)
5. Changing Key Count and saving it does not change the amount of columns in Compose. Only when exiting and entering the editor it changes (part of Scrolling ruleset playfields are not reloaded in editor after significant configuration changes #17127)
6. Approach Rate should not be there
7. Colours category should not be there
8. Tick rate is up for debate if it stays or not. (If it stays, this would require a ranking criteria entry)
9. Support for 10k+

Compose

Preview Give feedback

1. (User's high priority) Right click does not delete the current note that is hovered on by the cursor. Currently it selects and opens the context menu of that note. You now have to hold shift to delete the current note.
2. (User's high priority) You cannot zoom in the playfield. When zooming in the timeline above, the playfield should zoom with it like in osu!stable. The current workaround is to change the scroll speed in options. Match mania editor playfield time range with timeline zoom #28809
3. [Hold Ctrl + Scrollwheel] does not change snaps like in stable. You now have to hold shift to do this.
4. You can place on top of the same note, which creates a stacked note. This should not be possible in mania
5. You can place a note during a slider on the same column. This should not be possible.
6. [Hold Ctrl (+ Shift) + Up/Down arrow keys] does not change Playback Rate
7. Bookmarks is not a thing in the editor (Ctrl + B opens beatmap listing)
8. SVs should not be shown in editor playfield. Makes it quite impossible to work with when creating SV maps for tournaments. Only show SV during testing. A possible solution is to have 2 playfields in the editor, one for non-sv (So all normalized to 1x speed) and one with SV. Adjust osu!taiko and osu!mania editors to not visualise velocity changes by default #24550
9. [Automatically seek after placing objects] should default to off in mania
10. Snap lines should stay, even if the cursor is not hovering
11. White bars (1/1) should be thicker
12. Ctrl + H doesn't work in osu!mania editor #28412
    area:editor ruleset/osu!mania +2
    
13. Selecting notes and seeking with scroll wheel sometimes skips some notes during selecting
14. Massive performance drop on ranked SV maps (ex. /b/1572577, /b/2669198, /b/2603455) Degraded performance on beatmaps with lots of high BPM timing points #20918 Catch & mania editor - Performance drops while scrolling backwards with unloaded objects #24007 (read below)
15. Hitsound volume should be on the notes as well
16. When double clicking on a note, the corresponding hitsound should play. Currently it seeks to that note.
17. Density chart is missing (Implement the density bar chart from stable mania editor back into lazer #21660)
18. Hold note duration can't be modified in the playfield of the editor #19900
    area:editor priority:1 ruleset/osu!mania +3
    
19. Seeking to a snap with a note makes it disappear (Note disappears after placement on previous beat division in mania editor #30588)
20. When scrolling back, notes before the receptor line can appear
21. When scrolling through the snaps (Ctrl + Shift + Scroll), it does not change between common/triplets.
22. Show the snap used in inspector when selecting a note
23. Maps with high amount of keys does not fit the editor box. Columns overlap or go outside of the screen (https://osu.ppy.sh/beatmapsets/2038189#mania/4251190)

Timing

Preview Give feedback

1. The offset waveform on the right is handy but could have some improvements. The possibility to zoom in to finetune offset. Maybe have the graph be on top of the white line (Or make the white line somewhat transparent)
2. Selecting a timing point with no [Timing] or [Effect] enabled is impossible after selecting a timing point with [Timing] or [Effect]. This is probably due to the clone button interaction. But it hinders if you only want to add an Effect. A possible solution is to double click the timing point to select it. The current workaround this is to deselect the current timing point and select the empty timing point (probably related or even same as Can't move timing point using "Use current time" #23147)
3. Cannot press Delete to delete a timing point

Verify

Preview Give feedback

1. (Debatable due to mania ranking critaria) The Problem "There are no hitsounds" should be a warning

[smoogipoo]

Massive performance drop on ranked SV maps (ex. /b/1572577 and /b/2669198)

Note that this was linked to another issue claiming SVs as the culprit, however as far as I can tell this doesn't appear to be (at least, not always) SV-related.

The map that was brought up to me at COE was https://osu.ppy.sh/beatmapsets/1252675#mania/2603455, where I witnessed the editor entering some 3/4 of the way through the map. It looks like the editor's still keeping hitobjects alive when it shouldn't be - likely another edgecase with HitObjectLifetimeEntry.

While I can't repro the above map starting 3/4 of the way through, I can repro it all the same by just clicking on the timeline to that point in time:

2023-08-15.19-02-36.mp4

(notice how the pools are reporting many drawable instances are being used)

[peppy]

Performance potentially related to #24007

[Hydria]

(I was told to comment here so apologies if this is the wrong place)
Given how many SVs some maps use in mania, to have to switch from the compose tab to verify to place an sv and then switch back to make sure you're sure on what you're sving feels disconnected (this is mainly from someone who got used to the timing panel popout)
So a suggestion would be to use the timing panel to add the ability to see current bpm/sv values and then allow addition of new ones at the current timestamp. Quick mockup shown below:

[Sydosys]

This might fall under "You can place a note during a slider on the same column. This should not be possible." but I'd like to point out that one method for creating long note maps is to first place down the notes as regular notes, and then switch to the long note tool to extend those notes into holds. Stable's editor allows this, as using the hold tool to drag out a short note will extend it into a long note. However, doing this in lazer will just result in the long note stacking on top of the short note.

In Stable, if you are using the long note tool but you just click instead of dragging out the long note, you can place a short note, you can use this to replace a long note with a short note easily by just clicking at the start.

In Stable, to change the length of a hold note, you can drag from the beginning while the hold tool is selected to replace the old hold with the new one.

Just a few stable behaviors to keep in mind when you work on the issues with stacking, as these are all very important to the workflow of creating a long note map in my opinion.

There was another issue I found, but I'm having a hard time telling if it occurs solely in the editor, or if having the notes be unmoving just highlights it. I'm using a legacy skin, and the hold notes appear to end before they are supposed to. I am specifically running this on a Macbook M2 Pro, which could be part of the problem. See below:

[bdach]

I'm using a legacy skin, and the hold notes appear to end before they are supposed to

You're using a hack of a skin with "percy" ends or whatever. Those routinely exploit broken stuff like 30,000px high sprites. You should be happy it continues to work at all.

Out of scope of this issue.

[G4PLS]

Maybe another improvement could be to add the ability to select all notes on a line.
This would improve mapping in some cases. I for example map different instruments out on a single key and having to select all notes on one line is very tedious when wanting to experiment around with instruments.

Basically a CTRL+A for a single Mania Line/Mania Key