Support reading beatmap metadata from ID3 tags in editor #21189
Labels
Comments
frenzibyte
added
osu!framework issue
This was referenced Jan 16, 2023
bdach
added a commit
to bdach/osu
that referenced
this issue
Dec 27, 2024
…editor - Closes ppy#21189 - Supersedes / closes ppy/osu-framework#5627 - Supersedes / closes ppy#22235 The reason why I opted for a complete rewrite rather than a revival of that aforementioned pull series is that it always felt quite gross to me to be pulling framework's audio subsystem into the task of reading ID3 tags, and I also partially don't believe that BASS is *good* at reading ID3 tags. Meanwhile, we already have another library pulled in that is *explicitly* intended for reading multimedia metadata, and using it does not require framework changes. (And it was pulled in explicitly for use in the editor verify tab as well.) The hard and dumb part of this diff is hacking the gibson such that the metadata section on setup screen actually *updates itself* after the resources section is done doing its thing. After significant gnashing of teeth I just did the bare minimum to make work by caching a common parent and exposing an `Action?` on it. If anyone has better ideas, I'm all ears.
TheDark98
pushed a commit
to TheDark98/osu
that referenced
this issue
Jan 14, 2025
…editor - Closes ppy#21189 - Supersedes / closes ppy/osu-framework#5627 - Supersedes / closes ppy#22235 The reason why I opted for a complete rewrite rather than a revival of that aforementioned pull series is that it always felt quite gross to me to be pulling framework's audio subsystem into the task of reading ID3 tags, and I also partially don't believe that BASS is *good* at reading ID3 tags. Meanwhile, we already have another library pulled in that is *explicitly* intended for reading multimedia metadata, and using it does not require framework changes. (And it was pulled in explicitly for use in the editor verify tab as well.) The hard and dumb part of this diff is hacking the gibson such that the metadata section on setup screen actually *updates itself* after the resources section is done doing its thing. After significant gnashing of teeth I just did the bare minimum to make work by caching a common parent and exposing an `Action?` on it. If anyone has better ideas, I'm all ears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requires framework-side changes to retrieve ID3 tags using
BASS_ChannelGetTags.Discussed in #21177
Originally posted by toadsworth-jr November 8, 2022
In stable, importing an audio file that has ID3 tags present such as the song's title and artist gets automatically applied in the beatmap's respective metadata fields. In Lazer, this is absent, requiring the user to manually type out/copy the tags themselves.
The text was updated successfully, but these errors were encountered: