Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance on beatmaps with lots of high BPM timing points #20918

Open
Trung0246 opened this issue Oct 25, 2022 · 7 comments
Open

Degraded performance on beatmaps with lots of high BPM timing points #20918

Trung0246 opened this issue Oct 25, 2022 · 7 comments

Comments

@Trung0246
Copy link

Type

Game behaviour

Bug description

Song: https://osu.ppy.sh/beatmapsets/1182702#mania/2769068

Also have general performance issue when loading huge number of bpm tick but that probably my computer being slow (maybe even ryzen 3950x cannot handle this). Maybe the performance thing could be a separate github issue.

The right vertical scroll bar also go crazy for some part in the map but that probably due to the map abusing effects (~0:49).

Possible relevant but not sure if duplicate since I did unfocus then focus back to open the recording program: #20747

Screenshots or videos

osu._U3I5JIeS4q.mp4

Version

2022.1022.0

Logs

database.log
input.log
legacy-ipc.log
network.log
performance.log
runtime.log
updater.log

@bdach
Copy link
Collaborator

bdach commented Oct 25, 2022

The metronome cannot and should not attempt to tick correctly at 10k bpm. 10k bpm is (more or less) 3 beats per frame at 60fps. I assure you, you don't want to hear what that's like.

The performance issues are valid and I'll leave this open to track those, but are all side effects of the typical mania hacks to achieve note "freezing". This should be just supported better without hacks (i.e. #13158 (comment)).

@bdach bdach changed the title Metronome in editor doesn't tick correctly when being spammed with 1-10000 bpm in editor prior (with couple other relevant issues?) Degraded editor performance on beatmaps with lots of high BPM timing points Oct 25, 2022
@Trung0246
Copy link
Author

Trung0246 commented Oct 25, 2022

The metronome cannot and should not attempt to tick correctly at 10k bpm. 10k bpm is (more or less) 3 beats per frame at 60fps. I assure you, you don't want to hear what that's like.

Oh I was mean't the 140bpm part, not the 10kbpm part.

@bdach
Copy link
Collaborator

bdach commented Oct 25, 2022

Was hard to tell since the video in the OP has no audio. Just to confirm - you are running the game multithreaded, correct?

@Trung0246
Copy link
Author

Trung0246 commented Oct 25, 2022

Yes multithreaded per settings being set.
Also the bug should be present around 0:10

@peppy
Copy link
Member

peppy commented Oct 26, 2022

This is just going to be the start of a huge number of issues if we're trying to support these silly game-breaking beatmaps in the editor. I dunno.

@bdach
Copy link
Collaborator

bdach commented Dec 31, 2022

Expanding scope to generally cover these beatmaps everywhere rather than just editor.

@bdach bdach changed the title Degraded editor performance on beatmaps with lots of high BPM timing points Degraded performance on beatmaps with lots of high BPM timing points Dec 31, 2022
@bdach
Copy link
Collaborator

bdach commented Aug 15, 2023

Other examples: /b/1572577, /b/2669198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants