Merge pull request #11190 from nanaya/score-float-part2

Fix another float/int mismatch
ppy · May 2, 2024 · f73ea11 · f73ea11
2 parents 593cd0f + 49c51d3
commit f73ea11
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/Models/Traits/Scoreable.php b/app/Models/Traits/Scoreable.php
@@ -87,8 +87,8 @@ public function recalculateRank(): void
         switch ($this->getMode()) {
             case 'osu':
                 $totalHitCount = $totalHits / 300;
-                $ratio300 = $totalHits === 0 ? 1 : $this->count300 / $totalHitCount;
-                $ratio50 = $totalHits === 0 ? 1 : $this->count50 / $totalHitCount;
+                $ratio300 = (float) ($totalHits === 0 ? 1 : $this->count300 / $totalHitCount);
+                $ratio50 = (float) ($totalHits === 0 ? 1 : $this->count50 / $totalHitCount);
 
                 $this->rank = match (true) {
                     $ratio300 === 1.0 =>
@@ -109,8 +109,8 @@ public function recalculateRank(): void
 
             case 'taiko':
                 $totalHitCount = $totalHits / 300;
-                $ratio300 = $totalHits === 0 ? 1 : $this->count300 / $totalHitCount;
-                $ratio50 = $totalHits === 0 ? 1 : $this->count50 / $totalHitCount;
+                $ratio300 = (float) ($totalHits === 0 ? 1 : $this->count300 / $totalHitCount);
+                $ratio50 = (float) ($totalHits === 0 ? 1 : $this->count50 / $totalHitCount);
 
                 $this->rank = match (true) {
                     $ratio300 === 1.0 =>