Merge pull request #11189 from nanaya/score-rank-float

Fix score accuracy comparison
ppy · May 2, 2024 · 593cd0f · 593cd0f
2 parents 1a86fc2 + 099da54
commit 593cd0f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/Models/Traits/Scoreable.php b/app/Models/Traits/Scoreable.php
@@ -91,7 +91,7 @@ public function recalculateRank(): void
                 $ratio50 = $totalHits === 0 ? 1 : $this->count50 / $totalHitCount;
 
                 $this->rank = match (true) {
-                    $ratio300 === 1 =>
+                    $ratio300 === 1.0 =>
                         $this->shouldHaveHiddenRank() ? 'XH' : 'X',
                     $ratio300 > 0.9 && $ratio50 <= 0.01 && $countMiss === 0 =>
                         $this->shouldHaveHiddenRank() ? 'SH' : 'S',
@@ -113,7 +113,7 @@ public function recalculateRank(): void
                 $ratio50 = $totalHits === 0 ? 1 : $this->count50 / $totalHitCount;
 
                 $this->rank = match (true) {
-                    $ratio300 === 1 =>
+                    $ratio300 === 1.0 =>
                         $this->shouldHaveHiddenRank() ? 'XH' : 'X',
                     $ratio300 > 0.9 && $ratio50 < 0.01 && $countMiss === 0 =>
                         $this->shouldHaveHiddenRank() ? 'SH' : 'S',
@@ -131,7 +131,7 @@ public function recalculateRank(): void
 
             case 'fruits':
                 $this->rank = match (true) {
-                    $accuracy === 1 =>
+                    $accuracy === 1.0 =>
                         $this->shouldHaveHiddenRank() ? 'XH' : 'X',
                     $accuracy > 0.98 =>
                         $this->shouldHaveHiddenRank() ? 'SH' : 'S',
@@ -149,7 +149,7 @@ public function recalculateRank(): void
 
             case 'mania':
                 $this->rank = match (true) {
-                    $accuracy === 1 =>
+                    $accuracy === 1.0 =>
                         $this->shouldHaveHiddenRank() ? 'XH' : 'X',
                     $accuracy > 0.95 =>
                         $this->shouldHaveHiddenRank() ? 'SH' : 'S',