-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of action to reconnect branch at both side action #943
Conversation
Signed-off-by: Anne Tilloy <[email protected]>
src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a small fix needed for sonar.
src/main/java/com/powsybl/openloadflow/network/impl/Networks.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just rename the PR to "Added support of branch re-connection action" if you agree
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No. Only line opening at both sides is supported as remedial action in main branch. An error message throws if a user wants to simulate a one side modification or a line re-connection at both sides. During this feature supports, I rework on the action in
powsybl-core
because it is not adapted to open/close at one side only (powsybl/powsybl-core#2843).What kind of change does this PR introduce?
For the moment, only the support of a remedial action that connects at both side a line that was totally disconnected.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: