Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of action to reconnect branch at both side action #943

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

annetill
Copy link
Member

@annetill annetill commented Jan 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No. Only line opening at both sides is supported as remedial action in main branch. An error message throws if a user wants to simulate a one side modification or a line re-connection at both sides. During this feature supports, I rework on the action in powsybl-core because it is not adapted to open/close at one side only (powsybl/powsybl-core#2843).

What kind of change does this PR introduce?

For the moment, only the support of a remedial action that connects at both side a line that was totally disconnected.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@annetill annetill requested a review from obrix January 9, 2024 09:56
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
@geofjamg geofjamg self-requested a review January 26, 2024 10:33
Copy link
Member

@obrix obrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small fix needed for sonar.

Signed-off-by: Anne Tilloy <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeandemanged jeandemanged self-requested a review January 29, 2024 15:42
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just rename the PR to "Added support of branch re-connection action" if you agree

@annetill annetill changed the title Rework of line connection action Added support of action to reconnect branch at both side action Jan 29, 2024
@annetill annetill merged commit 5edcbaa into main Jan 29, 2024
6 checks passed
@annetill annetill deleted the line-connection-action branch January 29, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants