-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of LineConnectionAction to TerminalsConnectionAction #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne Tilloy <[email protected]>
jeandemanged
requested changes
Jan 3, 2024
...s-api/src/main/java/com/powsybl/security/json/action/TerminalConnectionActionSerializer.java
Outdated
Show resolved
Hide resolved
...-analysis-api/src/test/java/com/powsybl/security/json/JsonActionAndOperatorStrategyTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
commented
Jan 3, 2024
security-analysis/security-analysis-api/src/test/resources/ActionFileTestV1.0.json
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Merged
7 tasks
obrix
reviewed
Jan 10, 2024
...ecurity-analysis-api/src/main/java/com/powsybl/security/action/TerminalConnectionAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
EtienneLt
reviewed
Jan 11, 2024
...ecurity-analysis-api/src/main/java/com/powsybl/security/action/TerminalConnectionAction.java
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Jan 11, 2024
...ecurity-analysis-api/src/main/java/com/powsybl/security/action/TerminalConnectionAction.java
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Jan 11, 2024
...s-api/src/main/java/com/powsybl/security/json/action/TerminalConnectionActionSerializer.java
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Jan 11, 2024
...s-api/src/main/java/com/powsybl/security/json/action/TerminalConnectionActionSerializer.java
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Jan 11, 2024
...ity-analysis/security-analysis-api/src/main/java/com/powsybl/security/action/ActionList.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
EtienneLt
reviewed
Jan 16, 2024
...curity-analysis-api/src/main/java/com/powsybl/security/action/TerminalsConnectionAction.java
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Jan 16, 2024
...curity-analysis-api/src/main/java/com/powsybl/security/action/TerminalsConnectionAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anne Tilloy <[email protected]>
EtienneLt
approved these changes
Jan 16, 2024
jeandemanged
requested changes
Jan 16, 2024
...curity-analysis-api/src/main/java/com/powsybl/security/action/TerminalsConnectionAction.java
Outdated
Show resolved
Hide resolved
...curity-analysis-api/src/main/java/com/powsybl/security/action/TerminalsConnectionAction.java
Outdated
Show resolved
Hide resolved
...curity-analysis-api/src/main/java/com/powsybl/security/action/TerminalsConnectionAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
changed the title
Rework of line connection action to terminal connection action
Rework of LineConnectionAction to TerminalsConnectionAction
Jan 16, 2024
jeandemanged
approved these changes
Jan 16, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
7 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No, but line connection action support in powsybl-open-loadflow is much more complex that expected. Indeed, the real issue is that sometimes as remedial action, we want:
My understanding of the design is that we have to give open status both both side, always. Even if the terminal status (open or close) is not changed through the action.
What kind of change does this PR introduce?
Feature.
What is the current behavior?
See above limitations of LineConnectionAction
What is the new behavior (if this is a feature change)?
Removal of LineConnectionAction, reworked in new more generic TerminalsConnectionAction.
The side can be optionally specified. Not providing the side means operating all terminals. Furthermore, the element can be anything: line, transformers, tie line (through dangling lines), hvdc (through converter stations), etc. And more like generators, loads, etc....
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
maybe the identifiable type must be provided to ease integration, this would eventually be subject of another PR