Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of LineConnectionAction to TerminalsConnectionAction #2843

Merged
merged 12 commits into from
Jan 16, 2024

Conversation

annetill
Copy link
Member

@annetill annetill commented Jan 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No, but line connection action support in powsybl-open-loadflow is much more complex that expected. Indeed, the real issue is that sometimes as remedial action, we want:

  • Open or close a line ;
  • Open or close a line at one side only.

My understanding of the design is that we have to give open status both both side, always. Even if the terminal status (open or close) is not changed through the action.

What kind of change does this PR introduce?

Feature.

What is the current behavior?

See above limitations of LineConnectionAction

What is the new behavior (if this is a feature change)?

Removal of LineConnectionAction, reworked in new more generic TerminalsConnectionAction.

The side can be optionally specified. Not providing the side means operating all terminals. Furthermore, the element can be anything: line, transformers, tie line (through dangling lines), hvdc (through converter stations), etc. And more like generators, loads, etc....

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

maybe the identifiable type must be provided to ease integration, this would eventually be subject of another PR

Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged jeandemanged changed the title Rework of line connection action to terminal connection action Rework of LineConnectionAction to TerminalsConnectionAction Jan 16, 2024
Copy link

@annetill annetill merged commit e148a02 into main Jan 16, 2024
6 checks passed
@annetill annetill deleted the fix-line-connection-action branch January 16, 2024 10:41
@annetill annetill mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants