-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Attempt to fix the VC redist installation issues
- Try to avoid comparing against a hash from when the installer was built, since MS frequently updates the redist installer from that link. The normal signature verification can be used - Remove caching of the redist for the CI builds, since this resulted in it never being updated. #305
- Loading branch information
1 parent
4fee418
commit 43ec269
Showing
2 changed files
with
2 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,15 +82,7 @@ jobs: | |
|
||
- uses: microsoft/[email protected] | ||
|
||
- name: Cache VC redist | ||
id: cache-redist | ||
uses: actions/cache@v2 | ||
with: | ||
path: installer/windows/redist/vc_redist.x64.exe | ||
key: ${{ runner.os }}-redist-v1 | ||
|
||
- name: Fetch VC redist | ||
if: steps.cache-redist.outputs.cache-hit != 'true' | ||
run: | | ||
cd installer/windows | ||
mkdir redist | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters